Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved test classes to test sources #179

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Moved test classes to test sources #179

merged 1 commit into from
Feb 11, 2022

Conversation

remcowesterhoud
Copy link
Contributor

@remcowesterhoud remcowesterhoud commented Feb 10, 2022

Description

Somehow these tests ended up in the source files, instead of the test source files. Presumably due to the module split. This moves them back where they belong.

Also modified the junit dependency scope to test. Now that these files are moved the junit is no longer used outside of the test scope.

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually

Documentation:

  • Javadoc has been written
  • The documentation is updated

Somehow these tests ended up in the source files, instead of the test source files. Presumably due to the module split. This moves them back where they belong.

Also modified the junit dependency scope to test. Now that these files are moved the junit is no longer used outside of the test scope.
@github-actions
Copy link

github-actions bot commented Feb 10, 2022

Unit Test Results

  90 files    90 suites   4m 19s ⏱️
192 tests 192 ✔️ 0 💤 0
576 runs  576 ✔️ 0 💤 0

Results for commit 431cbcf.

♻️ This comment has been updated with latest results.

Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@remcowesterhoud remcowesterhoud merged commit 26aa007 into main Feb 11, 2022
@remcowesterhoud remcowesterhoud deleted the tests-move branch February 11, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants