Move containerized engine to different module #187
Merged
+61
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remcowesterhoud
force-pushed
the
engine-agent
branch
2 times, most recently
from
4cc2460
to
7482346
Compare
A new "engine-agent" module has been created. This module will be responsible for containerizing the engine and making it executable. This has been split from the "engine" module, because in the near future we will support using the engine with and without testcontainers. For people running without testcontainers we don't want to expose any of the container related stuff.
remcowesterhoud
force-pushed
the
engine-agent
branch
from
7482346
to
848b30d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new "engine-agent" module has been created. This module will be responsible for containerizing the engine and making it executable. This has been split from the "engine" module, because in the near future we will support using the engine with and without testcontainers. For people running without testcontainers we don't want to expose any of the container related stuff.
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: