Create a filters module #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new module "filters" has been introduced. This module will be responsible for filtering the record stream to find specific records. It has been extracted because this is a shared functionality, regardless of where the record stream comes from. In the future this might move to Zeebe as we have a similar functionality in that project which we could reuse.
Moved all filters to the filters module. No code changes have been made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new module "filters" has been introduced. This module will be responsible for filtering the record stream to find specific records.
It has been extracted because this is a shared functionality, regardless of where the record stream comes from. In the future this might move to Zeebe as we have a similar functionality in that project which we could reuse.
Related issues
Relates to #7. In order to prevent duplication we need this filter logic in a reusable place.
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: