-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
40 code formatting #223
40 code formatting #223
Conversation
- bind spotless to process-sources phase - add markdown formatting on level of parent project - put java/pom formatting into the inheritable settings
(refactored steps to run outside of test matrix)
@remcowesterhoud Not so sure on the latest commits. Maybe we want to run the code formatting before we run the tests. But otherwise it doesn't really matter 🤔 So please let me know how you want the CI pipeline to work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pihme! Looks great!
❓ I'm assuming the code styles you've added are the same ones we use in Zeebe?
🔧 Line 346 of the root pom still has a comment mentioning it's a Google code format plugin. This is not really accurate anymore. (I can't comment on this line for some reason 🤔)
For the pipeline question you asked. I think we should run the code formatting before the tests. The formatting shouldn't break any code, but if they ever have a bug that does it'd be nice to catch it immediately in our tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to merge 👍
Description
Related issues
closes #40
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: