Support ProcessInstanceBatch records #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the new ProcessInstanceBatch ValueType to the RecordLogger. There is no assertions over this record and no relevant context for users in it. Because of this we can leave the logging empty.
Implements the new whileEqualPrefix with startAtKey method. This was introduces in Zeebe for terminating child instances in batches.
koevskinikola
approved these changes
May 2, 2023
There was a problem hiding this comment.
LGTM 👍
@remcowesterhoud I haven't asked Bors to merge the PR, as I just have a clarifying question.
filters/src/main/java/io/camunda/zeebe/process/test/filters/logger/RecordStreamLogger.java
Show resolved
Hide resolved
|
bors merge |
|
Build succeeded: |
ghost
merged commit 
|
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.1
git worktree add -d .worktree/backport-746-to-stable/8.1 origin/stable/8.1
cd .worktree/backport-746-to-stable/8.1
git checkout -b backport-746-to-stable/8.1
ancref=$(git merge-base 15e4bfdb00b3f2b0995222d10f0239a89e4c07a8 bb98534a21c6ac7c01961759c2150a9e72bfd30d)
git cherry-pick -x $ancref..bb98534a21c6ac7c01961759c2150a9e72bfd30d |
|
Successfully created backport PR for |
ghost
pushed a commit
that referenced
this pull request
May 2, 2023
ghost
pushed a commit
that referenced
this pull request
May 3, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the ZPT snapshot tests by adding 2 fixes:
whileEqualPrefixmethod with astartAtKeyProcessInstanceBatchvalue type to theRecordLoggerRelated issues
closes #745
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: