Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video controls #121

Merged
merged 10 commits into from
Mar 5, 2024
Merged

Conversation

PhilippMDoerner
Copy link
Contributor

No description provided.

@can-lehmann
Copy link
Owner

What is your opinion on merging the Video and Media Controls examples?

@PhilippMDoerner
Copy link
Contributor Author

Works for me. I was doing most of these in tunnel-vision mode: Get widget, make example according to guidelines, next.

It's a fair assessment to make that the video-controls and video-player example are going to be highly similar.

The main worry I might have is that the video example demonstrates controlling the mediastream on your own as well and I'm not sure whether that might be "too much stuff" in one widget example to have the media-control widget, video widget and buttons to control the media stream in one thing.

If that is still okay then I'll just merge the examples.

@PhilippMDoerner
Copy link
Contributor Author

Examples have been unified (Though it doesn't necessarily look the prettiest given how you see 2 controls: The controls of the Video Widget itself and the controls of this VideoControls widget.

@can-lehmann can-lehmann added this to the Owlkettle 3.0.0 milestone Mar 5, 2024
@can-lehmann can-lehmann merged commit 7c73fce into can-lehmann:main Mar 5, 2024
3 checks passed
@PhilippMDoerner PhilippMDoerner deleted the add-video-controls branch March 5, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants