Client: add silent property #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
force-pushed
the
feat/silent
branch
from
02ff6a0
to
3a92e2b
Compare
peaBerberian
added
server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a request from some external (not Canal+) partners to not output player logs while they were debugging issues because they were too verbose and their debugger didn't perform well.
Considering that the main scenario where we want to output the most logs on our side are when debugging issues, this is not something we want in cases like here where we're both testing the same application.
I propose this solution instead: When importing dynamically (at application runtime) the client script, a caller might set a supplementary
silent: trueoption, which will allow to still send the log to the RxPaired-server, yet will not output the log in the usual console.That way, people debugging on regular browser debuggers will not be bothered by logs, yet we'll still be able to see them through RxPaired.