Debug: update buffer graph maximum size so it becomes more readable for lengthy contents #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or long contents When displaying the RxPlayer's debug element, a graph describing the audio, video and text qualities in the various buffers might be displayed. At maximum, that graph could display 10000 seconds of content, which made in that case the graph poorly readable. I now chose to reduce it to maximum 30 minutes, as you rarely intend to see more when displaying debug information, making it much more readable.
src/core/api/debug/buffer_graph.ts
Outdated
| maximumPosition = maximumPoint; | ||
| minimumPosition = maximumPoint - BUFFER_WIDTH_IN_SECONDS; |
There was a problem hiding this comment.
How is it possible to have currentTime to undefined?
If currentTime is undefined we may have an issue in
minimumPoint = Math.min(currentTime, minimumPoint);
that may return NaN ?
There was a problem hiding this comment.
You're right it seems it cannot be undefined here. I will update
Florent-Bouisset
approved these changes
Nov 21, 2023
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When displaying the RxPlayer's debug element, a graph describing the audio, video and text qualities in the various buffers might be displayed.
At maximum, that graph could display 10000 seconds of content, which made in that case the graph poorly readable.
I now chose to reduce it to maximum 30 minutes, as you rarely intend to see more when displaying debug information, making it much more readable.