Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:(worker) debug element display buffer in worker mode #1438

Merged
merged 30 commits into from
Jun 17, 2024

Conversation

Florent-Bouisset
Copy link
Collaborator

This PR aims to add the segment inventory sink representation in the debug element of the RxPayer when it's working in worker mode.

image

@peaBerberian
Copy link
Collaborator

peaBerberian commented May 13, 2024

when it's working in worker mode.

Just in case for users that might read that PR, by "worker mode" we mean here the "multithreading" mode which is available when the experimental MULTI_THREAD feature is enabled ("worker" here refers to the HTML WebWorker we instantiate to run logic in another thread).

For now we provide under that mode less information in the debug element that can be displayed when adding the optional DEBUG_ELEMENT feature and calling the createDebugElement RxPlayer method.
It sounds like a rare scenario but it isn't at all, most notably at Canal+, where the "multithreading" mode is relied on on many devices.

@peaBerberian peaBerberian added this to the 4.1.0 milestone Jun 10, 2024
@peaBerberian peaBerberian added Priority: 2 (Medium) This issue or PR has a medium priority. MultiThread Concerns specifically the multithreaded mode of the RxPlayer labels Jun 10, 2024
@peaBerberian peaBerberian mentioned this pull request Jun 13, 2024
@Florent-Bouisset Florent-Bouisset force-pushed the feat/debug-elt-buffer-in-worker-mode branch from a53bfa7 to 8e5c1c7 Compare June 13, 2024 15:44
@Florent-Bouisset Florent-Bouisset changed the title Feat/debug elt buffer in worker mode feat:(worker) debug element display buffer in worker mode Jun 14, 2024
@Florent-Bouisset Florent-Bouisset force-pushed the feat/debug-elt-buffer-in-worker-mode branch from 8e5c1c7 to 7c18b67 Compare June 14, 2024 14:50
@Florent-Bouisset Florent-Bouisset force-pushed the feat/debug-elt-buffer-in-worker-mode branch from bb41e38 to 66e4e52 Compare June 17, 2024 15:51
@peaBerberian peaBerberian merged commit 65d557e into dev Jun 17, 2024
6 checks passed
@peaBerberian peaBerberian deleted the feat/debug-elt-buffer-in-worker-mode branch July 26, 2024 16:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MultiThread Concerns specifically the multithreaded mode of the RxPlayer Priority: 2 (Medium) This issue or PR has a medium priority.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants