Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle NMEA0183v4 Tag Block for PCDIN and MXPGN sentences #257

Closed
macjl opened this issue Oct 11, 2023 · 1 comment · Fixed by #258
Closed

Handle NMEA0183v4 Tag Block for PCDIN and MXPGN sentences #257

macjl opened this issue Oct 11, 2023 · 1 comment · Fixed by #258

Comments

@macjl
Copy link

macjl commented Oct 11, 2023

Hello,

Related to this bug : SignalK/signalk-server#1645

CanboatJS seems to discard NMEA0183 sentences when there contain Tag Blocks. Examples :

\s:serial,c:1696759211*3D\$MXPGN,01F200,2838,00441FFFFF7FFFFF*12
\s:serial,c:1696759212*3E\$MXPGN,01F214,6824,03BA0A0A00FFFF73*1C
\s:serial,c:1696759212*3E\$MXPGN,01F214,6824,0283050C00FFFF73*63
\s:serial,c:1696759212*3E\$PCDIN,01F200,B35A7B99,38,003A1FFFFF7FFFFF*2A
\s:serial,c:1696759212*3E\$PCDIN,01F201,B35A79DF,38,00FFFFFFFFDB8D6E05FF7FC80D4800FFFFFFFF7F000000007F7F*29
\s:serial,c:1696759212*3E\$PCDIN,01F214,B35A7A3B,E0,008805FF7FFFFF7E*51
\s:serial,c:1696759212*3E\$PCDIN,01F214,B35A7A3B,E0,0183055500FFFF7E*2A

Without Tag Blocks, these sentences are correctly understood by CanboatJS.
sbender9 added a commit that referenced this issue Oct 15, 2023
@sbender9
fix: handle 0183 messages with v4 tag blocks
e83ef40 
fixes #257
@sbender9 sbender9 mentioned this issue Oct 15, 2023
Merged
sbender9 added a commit that referenced this issue Oct 15, 2023
@sbender9
fix: handle 0183 messages with v4 tag blocks (#258)
c23b1f9 
fixes #257
@sbender9
Copy link
Member

@macjl fix released in v2.5.5 , can you try it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle 0183 messages with v4 tag blocks canboat/canboatjs
2 participants
@sbender9 @macjl