Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Shipmodul MXPGN hex parsing. #191

Closed
wants to merge 1 commit into from
Closed

Conversation

Sjoerd02
Copy link

Big- Little- Endian issue parsing MXPGN / shipmodul
Shipmodul is sending hex from right to left, SK is expecting from left to right.

see also https://signalk-dev.slack.com/archives/C03F1MKQG/p1633812967355500

Big- Little- Endian  issue parsing MXPGN / shipmodul 
Shipmodul is sending hex from right to left, SK is expecting from left to right.

see also https://signalk-dev.slack.com/archives/C03F1MKQG/p1633812967355500
@sbender9
Copy link
Member

The MXPGN test fails now. But I don't remember where I got that data and it doesn't look valid anyway.

I tested this stuff way back with SeaSmart hardware and the Navico GoFree stuff. I find it very hard to believe that I would have missed this!

I think Shipmodul got it backwards

@sbender9
Copy link
Member

Where did you get this:

"one CAN frame (a NMEA 2000 Single Frame message) as one 64-bit 'little endian' word."

@Sjoerd02
Copy link
Author

Sjoerd02 commented Mar 28, 2022

Where did you get this:

"one CAN frame (a NMEA 2000 Single Frame message) as one 64-bit 'little endian' word."

The statement I got in a mail from Shipmodul asking how to read the MXPGN.

Possibly the 64 bit is pointing to my example explicitly.

http://www.shipmodul.com/downloads/manuals/MiniPlex-3_3.14_EN.pdf - page 92:

2022-03-28_21h46_11

@Sjoerd02
Copy link
Author

To me it looks like the encodeMXPGN is also have some code to invert the Hex.
We tested the same code in the parseMXPGN but it did not actually store buff.

Checking the history, it looks like the MXPGN was introduced 8 Feb '21 and corrected on 3 Mar'21 corrected.
I did not test the encoding part of the code.

I tested this stuff way back with SeaSmart hardware and the Navico GoFree stuff. I find it very hard to believe that I would have missed this!

I was not aware MXPGN was used by other devices as well, it did not pop-up in Google search.

@sbender9
Copy link
Member

Sorry for the horrible delay: #277

@sbender9 sbender9 closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants