ease and modernise installation a bit #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess work as expected
|
Hello! Thanks for taking a look. Well, what should have been trivial changes lead to bizarre rabbitholes around make behaviour. It's all useful experience I guess. Good point, I will change to the most recent commit |
|
Oh also there was a little associated commentary/background with this PR but it was on internal slack, I didn't know you would see the PR - the tool relies on linasm but doesn't actually reference it in the makefile or setup so compiliation couldn't be achieved as written |
…ep shared lib post compilation, + minor qol tweaks
|
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.