Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build executables for Free/Net/OpenBSD #506

Merged
merged 3 commits into from
Jul 6, 2024
Merged

Conversation

dbohdan
Copy link
Contributor

@dbohdan dbohdan commented Jul 5, 2024

Could you attach BSD executables to future releases? This PR updates build-all.sh to build them.

Use maximum ZIP compression.

Remove the `version` variable as it appears unused.
@candid82
Copy link
Owner

candid82 commented Jul 6, 2024

@dbohdan Thanks! I'll give it a try.

@candid82 candid82 merged commit 3310f21 into candid82:master Jul 6, 2024
1 check passed
@candid82
Copy link
Owner

candid82 commented Jul 7, 2024

@dbohdan Could you please test BSD binaries from here?

@dbohdan
Copy link
Contributor Author

dbohdan commented Jul 7, 2024

You're welcome! Thanks for merging this. It is a convenient change for me. I have added Joker to my list of projects with official NetBSD binaries.

I can confirm the BSD binaries work on their platforms. The OpenBSD binary works on OpenBSD 7.3 but not 7.5 because the ABI has changed. OpenBSD provides no stable ABI or ABI compatibility shims, so the binaries are more short-lived than those for FreeBSD and NetBSD. A newer version of Go will build for 7.5 (see golang/go#63900).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants