Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have macpan2 infer missing values in initial state vecs for internally calculated quantities? #133

Closed
papsti opened this issue Nov 14, 2023 · 1 comment
Assignees
Labels
engine adaptor Component: R-side data structure for defining engine-level models enhancement New feature or request

Comments

@papsti
Copy link
Collaborator

papsti commented Nov 14, 2023

from a draft of the quickstart vignette:


## SIR model simulator -------------------------
sir_simulator <- mp_tmb_simulator(
  dynamic_model = sir,
  vectors = list(
    state = c(S = 999, I = 1, R = 0),
    rate = c(beta = 0.25, gamma = 0.1, lambda = NA)
  ),
  time_steps = 100
)

Note that we've specified NA for lambda as it will be calculated for us using the force of infection functional form.


from @bbolker: is this required, or could macpan2 assume that unspecified values are set to NA automatically? (There could be an implicit/explicit design tradeoff here - i.e. it would be convenient to do this automatically but might be better to force users to be explicit ...)

@papsti papsti added enhancement New feature or request engine adaptor Component: R-side data structure for defining engine-level models labels Nov 14, 2023
@stevencarlislewalker
Copy link
Member

Must also be robust to the order of values

@stevencarlislewalker stevencarlislewalker moved this to 🏗 In progress in Roadmap Nov 15, 2023
@stevencarlislewalker stevencarlislewalker self-assigned this Nov 15, 2023
stevencarlislewalker added a commit that referenced this issue Nov 15, 2023
@stevencarlislewalker stevencarlislewalker moved this from 🏗 In progress to ✅ Done in Roadmap Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine adaptor Component: R-side data structure for defining engine-level models enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants