Stop using TaliskerRequestsTransport #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least for now stop using the TaliskerRequestsTransport. In practice, for flask apps it was not used in the apps/workers because FlaskSentry was explicitly setting a None 'transport' in the client kwargs. This change makes sure that the same default raven (threaded) transport is used by logging in the main process. This will mitigate the deadlocks described in prometheus/client_python#1076 (comment) because there will be no prometheus instrumentation for sentry requests.
|
This is a cleaner alternative to #610 |
verterok
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least for now stop using the TaliskerRequestsTransport.
In practice, for flask apps it was not used in the apps/workers because FlaskSentry was explicitly setting a None 'transport' in the client kwargs.
This change makes sure that the same default raven (threaded) transport is used by logging in the main process. This will mitigate the deadlocks described in
prometheus/client_python#1076 (comment) because there will be no prometheus instrumentation for sentry requests.