Rearchitect site for npm publishing #39
Conversation
|
No ./run found. Unable to start demo. |
|
@barrymcgee Your published package doesn't have a package.json: Checking package: |
|
The build created appears to be a compiled version of the site (I'm not sure what the site is in this case). I don't think we want to upload this to NPM. https://github.com/react-bootstrap/react-bootstrap/blob/master/package.json This could be changed after this PR to unblock others. In that case I am happy with this. |
|
@WillMoggridge is this ready for another review? If so, please update the labels. |
| "@storybook/addon-links": "^3.2.13", | ||
| "@storybook/addon-info": "^3.2.14" | ||
| }, | ||
| "version": "0.0.5", |
There was a problem hiding this comment.
Dropping the version from 0.1.0 to 0.0.5?
There was a problem hiding this comment.
I think this is fine, that is the current version on NPM and 0.0.x may be a better indication of the project.
| @@ -1,6 +1,6 @@ | |||
| import React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
| import './Accordion.css'; | |||
| //import './Accordion.css'; | |||
There was a problem hiding this comment.
Should this be commented out?
There was a problem hiding this comment.
I think it should not be commented and explicitly load the CSS.
Done
After digging into a little bit, I realised that the structure scaffolded out from
create-react-appis not optimal for publishing a component library to NPM.[1] facebook/create-react-app#907 (comment)
On the same thread, I noted where a team had forked create-react-app however for exactly this purpose so I've pulled out the work I've completed up until now and dropped it into that structure instead with Percy and Storybook.
Everything looks in order and the lib now builds as I'd expect and I can publish to npm, however, the app does not seem to be exporting modules correctly as when I try to import it and use a Button component, this happens:
https://codesandbox.io/s/03jv971v3n
Any ideas @anthonydillon or @Lukewh ?
Fixes #40