fix: raise "gdb not found" as soon as detected (LP: #2031919) #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version would actually simply return invalid values instead of raising, and the code that would raise would first *use* said values, leading to crashes, despair, and bug reports. Fixes LP: #2031919
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
==========================================
- Coverage 82.81% 82.81% -0.01%
==========================================
Files 91 91
Lines 18706 18713 +7
==========================================
+ Hits 15492 15497 +5
- Misses 3214 3216 +2
|
bdrung
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version would actually simply return invalid values instead
of raising, and the code that would raise would first use said values,
leading to crashes, despair, and bug reports.
In addition, this PR contains some more type hints (that would have caught this!!) and a small drive-by cosmetic fix.