Address complaints from pylint extensions #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
=======================================
Coverage 82.77% 82.77%
=======================================
Files 98 98
Lines 20171 20171
Branches 3268 3268
=======================================
Hits 16697 16697
Misses 2956 2956
Partials 518 518 ☔ View full report in Codecov by Sentry. |
The pylint `redefined_variable_type` extension complains: ``` ************* Module tests.integration.test_problem_report tests/integration/test_problem_report.py:156:8: R0204: Redefinition of tests type from list to dict (redefined-variable-type) ************* Module apport data/apport:824:4: R0204: Redefinition of fds type from list to array.array (redefined-variable-type) ``` Use different variable names.
``` ************* Module apport.report apport/report.py:1245:15: W0714: Overlapping exceptions (OSError is an ancestor class of urllib.error.URLError) (overlapping-except) ************* Module apport.crashdb apport/crashdb.py:311:19: W0714: Overlapping exceptions (OSError is an ancestor class of urllib.error.URLError) (overlapping-except) ************* Module apport.packaging_impl.apt_dpkg apport/packaging_impl/apt_dpkg.py:449:15: W0714: Overlapping exceptions (urllib.error.URLError is an ancestor class of urllib.error.HTTPError) (overlapping-except) apport/packaging_impl/apt_dpkg.py:1720:19: W0714: Overlapping exceptions (urllib.error.URLError is an ancestor class of urllib.error.HTTPError) (overlapping-except) apport/packaging_impl/apt_dpkg.py:1770:19: W0714: Overlapping exceptions (urllib.error.URLError is an ancestor class of urllib.error.HTTPError) (overlapping-except) apport/packaging_impl/apt_dpkg.py:1781:19: W0714: Overlapping exceptions (urllib.error.URLError is an ancestor class of urllib.error.HTTPError) (overlapping-except) ```
bdrung
force-pushed
the
fix-pylint-extensions
branch
from
2e174cb
to
9486594
Compare
schopin-pro
approved these changes
Oct 4, 2024
|
Coverage was angry because you touched error paths that aren't yet tested, I'm fine with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pylint
redefined_variable_typeextension complains:Use different variable names.