com.ubuntu.apport.policy: fix order of entries #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
==========================================
+ Coverage 82.72% 82.73% +0.01%
==========================================
Files 98 99 +1
Lines 20144 20159 +15
Branches 3172 3173 +1
==========================================
+ Hits 16664 16679 +15
Misses 2959 2959
Partials 521 521 ☔ View full report in Codecov by Sentry. |
The `/usr/share/polkit-1/actions/com.ubuntu.apport.policy` PolicyKit actions file does not validate against the provided `/usr/share/polkit-1/policyconfig-1.dtd`: ``` $ xmllint --noout --nonet --dtdvalid /usr/share/polkit-1/policyconfig-1.dtd /usr/share/polkit-1/actions/com.ubuntu.apport.policy /usr/share/polkit-1/actions/com.ubuntu.apport.policy:10: element action: validity error : Element action content does not follow the DTD, expecting (vendor? , vendor_url? , description+ , message+ , icon_name? , defaults , annotate*), got (description message annotate defaults ) /usr/share/polkit-1/actions/com.ubuntu.apport.policy:22: element action: validity error : Element action content does not follow the DTD, expecting (vendor? , vendor_url? , description+ , message+ , icon_name? , defaults , annotate*), got (description message annotate annotate defaults ) Document /usr/share/polkit-1/actions/com.ubuntu.apport.policy does not validate against /usr/share/polkit-1/policyconfig-1.dtd ``` Move some annotations around to make it validate. Let the CI depend on libxml2-utils for the xmllint binary and on polkitd for providing `/usr/share/polkit-1/policyconfig-1.dtd`. Bug: https://launchpad.net/bugs/2084152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/usr/share/polkit-1/actions/com.ubuntu.apport.policyPolicyKit actions file does not validate against the provided/usr/share/polkit-1/policyconfig-1.dtd:Move some annotations around to make it validate.
Bug: https://launchpad.net/bugs/2084152