-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is-required label to required fields #1365
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
- Coverage 72.48% 71.86% -0.62%
==========================================
Files 13 14 +1
Lines 1072 1102 +30
==========================================
+ Hits 777 792 +15
- Misses 295 310 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
For |
and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with some notes. You can ignore if you want, I don't think it makes too much of a difference. Otherwise you can reach out to the page owners or Lazlo
9a6e5ec
to
9b10c2e
Compare
Done
QA
*
on the labelsIssue / Card
Fixes WD-14682
Screenshots
[if relevant, include a screenshot]