Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is-required label to required fields #1365

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Sep 6, 2024

Done

  • Add "is-required" class to required fields for /data/mongodb#get-in-touch and /data/kafka#get-in-touch contact forms
  • The Jira issue reports a "Not Provided" payload for the required fields, this could not be replicated locally so this PR should explicitly tell users to fill up the forms with the required labels

QA

  • Go to /data/mongodb#get-in-touch and /data/kafka#get-in-touch
  • See that the contact fields have required * on the labels

Issue / Card

Fixes WD-14682

Screenshots

[if relevant, include a screenshot]

@webteam-app
Copy link

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.86%. Comparing base (6ea4949) to head (9a6e5ec).
Report is 172 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1365      +/-   ##
==========================================
- Coverage   72.48%   71.86%   -0.62%     
==========================================
  Files          13       14       +1     
  Lines        1072     1102      +30     
==========================================
+ Hits          777      792      +15     
- Misses        295      310      +15     
Flag Coverage Δ
python 71.86% <ø> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petesfrench
Copy link
Contributor

For /data/kafka#get-in-touch the 'phone number' field isn't actually required in Marketo https://na-sjg.marketodesigner.com/m#FOP5522. I don't know if this intentional or not

@petesfrench
Copy link
Contributor

and /data/mongodb#get-in-touch for 'job title' and 'company name' are not required https://na-sjg.marketodesigner.com/m#FOP4903
I am not sure if we should follow Marketo or the copydoc (which I haven't found)

Copy link
Contributor

@petesfrench petesfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some notes. You can ignore if you want, I don't think it makes too much of a difference. Otherwise you can reach out to the page owners or Lazlo

@britneywwc britneywwc merged commit fd85b9b into canonical:main Sep 17, 2024
8 checks passed
@britneywwc britneywwc deleted the forms-payload branch September 17, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants