Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Build /what-is-postgresql page #1368

Merged
merged 11 commits into from
Sep 17, 2024
Merged

feat: Build /what-is-postgresql page #1368

merged 11 commits into from
Sep 17, 2024

Conversation

petesfrench
Copy link
Contributor

@petesfrench petesfrench commented Sep 9, 2024

Done

  • Build the 'what-is-postgresql' page based on the copydoc and design

Flyby

  • Remove unused comment from styles.scss

QA

  • Check out the demo
  • Check that the content matches that in the copydoc
  • Check the content is visible and logically laid out on all screen sizes

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-13768

@webteam-app
Copy link

@petesfrench
Copy link
Contributor Author

@mattea-turic This is ready for review, just waiting on some the assets

@lizzochek
Copy link
Contributor

Was it agreed to remove this image or are we waiting for it?
Screenshot 2024-09-12 at 14 12 33

templates/data/postgresql/what-is-postgresql.html Outdated Show resolved Hide resolved
templates/data/postgresql/what-is-postgresql.html Outdated Show resolved Hide resolved
templates/data/postgresql/what-is-postgresql.html Outdated Show resolved Hide resolved
templates/data/postgresql/what-is-postgresql.html Outdated Show resolved Hide resolved
</section>

<section class="p-section">
<div class="row--50-50-on-large">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not keeping 50-50 on medium& @mattea-turic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided not to as it look a little unbalance (lots on the right, very little on the left):
image
But we should get the opinion of @mattea-turic

@lizzochek
Copy link
Contributor

Please get design approved and image added and ping me for another review in case of any changes

@mattea-turic
Copy link
Collaborator

This was mb as I did have it like that in the design, but could you remove the two 24px of padding so that only the 64px remains?
Screenshot 2024-09-12 at 14 27 48

And could you pls use the same styling for this section:
Screenshot 2024-09-12 at 14 42 54
As you did for this section:
Screenshot 2024-09-12 at 14 43 32

Currently, the HOCs have some deprecated items so iirc I was swapping the layers in that first section to use from the updated library. But I suppose I forgot to do it for the second section which has caused inconsistency between them now. So, I think I'll avoid messing with the layers of the HOCs to avoid this in the future, esp. since there'll ofc be updates in the future

@petesfrench
Copy link
Contributor Author

@mattea-turic Can you take another look here. I have upgraded the Vanilla version. I also applied some minor changes to https://canonical-com-1368.demos.haus/core/features/ota-updates

@mattea-turic
Copy link
Collaborator

as per my comment in MM, it looks good and I'll design +1 pending the change(s)

@petesfrench petesfrench merged commit 849d7a2 into main Sep 17, 2024
9 checks passed
@petesfrench petesfrench deleted the wd-13768 branch September 17, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants