Add suport for CIS hardened and SercureBoot systems #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves away from debugfs when detecting and disabling the i40e NICs handling of LLDP. debugfs is not available on CIS-hardened and SecureBoot systems. This change used ethtool in its place
This changes the i40e NIC detection from using the kern.log to /sys/class/net
|
We've tested this patch on a CIS-hardened and SecureBoot system |
wolsen
requested changes
Jan 8, 2024
Adding unittest
|
@wolsen Hello, Could you please review this PR once more and my PR as well? basic unit tests for this repo isn't working well. so I believe it should be removed. Thanks in advance! |
wolsen
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.