-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump to Scenario 7 #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I was trying to fix the tests and accidentally created a duplicated PR, sorry for the duplicated work. I closed my PR. If you search "changed_event", there are a few other interfaces (and a README) that have it. Shall we update them all? |
Sorry, that might have been my fault. I thought you were going to get things working with pinned versions and I'd figure out the upgrading situation (which turned out to be way simpler than I thought). I might have misunderstood - sorry if I trod on your things.
Ah, you're right, those should be fixed as well. Why is it that they don't show up as failures? Do I have to run the matrix to have that happen? |
Only the matrix tests for interfaces (triggered by this script) will run all tests, I think the unit tests and integration tests only run one interface as a validation. |
Adjust the versions to use ops-scenario 7.0 (including connected packages) and adjust the one test that needs adjusting (as far as I can tell, there are no others).