Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to Scenario 7 #177

Merged
merged 9 commits into from
Sep 26, 2024
Merged

Conversation

tonyandrewmeyer
Copy link
Contributor

Adjust the versions to use ops-scenario 7.0 (including connected packages) and adjust the one test that needs adjusting (as far as I can tell, there are no others).

Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IronCore864
Copy link
Contributor

I was trying to fix the tests and accidentally created a duplicated PR, sorry for the duplicated work. I closed my PR.

If you search "changed_event", there are a few other interfaces (and a README) that have it. Shall we update them all?

@tonyandrewmeyer
Copy link
Contributor Author

I was trying to fix the tests and accidentally created a duplicated PR, sorry for the duplicated work. I closed my PR.

Sorry, that might have been my fault. I thought you were going to get things working with pinned versions and I'd figure out the upgrading situation (which turned out to be way simpler than I thought). I might have misunderstood - sorry if I trod on your things.

If you search "changed_event", there are a few other interfaces (and a README) that have it. Shall we update them all?

Ah, you're right, those should be fixed as well. Why is it that they don't show up as failures? Do I have to run the matrix to have that happen?

@IronCore864
Copy link
Contributor

Why is it that they don't show up as failures?

Only the matrix tests for interfaces (triggered by this script) will run all tests, I think the unit tests and integration tests only run one interface as a validation.

@tonyandrewmeyer tonyandrewmeyer merged commit fa0526b into canonical:main Sep 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants