feat(reactive): run charm build in verbose mode #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengau
force-pushed
the
work/924/CRAFT-3424
branch
from
9977710 to
e41c932
Compare
While a user could previously have added `--verbose` to `reactive-charm-build-arguments`, this automatically adds `--verbose` if the user hasn't specified a log level. The verbose text gets handled by craft-cli anyway, but this changes the default so the text gets added to the log.
lengau
force-pushed
the
work/924/CRAFT-3424
branch
from
e41c932 to
35414e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While a user could previously have added
--verbosetoreactive-charm-build-arguments, this automatically adds--verboseif the user hasn't specified a log level.The verbose text gets handled by craft-cli anyway, but this changes the default so the text gets added to the log.
Spread test failures are unrelated: #2023
Fixes #924