Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLflow Kserve UAT #42

Closed
wants to merge 5 commits into from
Closed

MLflow Kserve UAT #42

wants to merge 5 commits into from

Conversation

misohu
Copy link
Member

@misohu misohu commented Oct 23, 2023

Add UAT for MLflow Kserve integration. To properly test it you need to deploy mlflow with kubeflow according to these instructions. After that you need to add three extra relations (for k-serve integration).

juju relate kserve-controller:service-accounts resource-dispatcher:service-accounts
juju relate kserve-controller:secrets resource-dispatcher:secrets
juju relate kserve-controller mlflow-minio

@misohu misohu requested a review from a team October 23, 2023 12:57
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @misohu. I left some comments

tests/notebooks/mlflow-kserve/mlflow-kserve.ipynb Outdated Show resolved Hide resolved
tests/notebooks/mlflow-kserve/mlflow-kserve.ipynb Outdated Show resolved Hide resolved
tests/notebooks/mlflow-kserve/mlflow-kserve.ipynb Outdated Show resolved Hide resolved
tests/notebooks/mlflow-kserve/mlflow-kserve.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the PR's instructions in the notebook? Sth like Requirements/Prerequisites?
Refering to those

juju relate kserve-controller:service-accounts resource-dispatcher:service-accounts
juju relate kserve-controller:secrets resource-dispatcher:secrets
juju relate kserve-controller mlflow-minio

tests/notebooks/mlflow-kserve/mlflow-kserve.ipynb Outdated Show resolved Hide resolved
tests/notebooks/mlflow-kserve/mlflow-kserve.ipynb Outdated Show resolved Hide resolved
@misohu
Copy link
Member Author

misohu commented Oct 27, 2023

Fixed thanks @orfeas-k

Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @misohu :)

@misohu misohu mentioned this pull request Oct 27, 2023
@orfeas-k orfeas-k closed this Oct 27, 2023
@orfeas-k orfeas-k deleted the KF-4903-kserve-mlflow-integration branch November 14, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants