Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for python3-requests 2.32.2 #5434

Closed
eaglegai opened this issue Jun 24, 2024 · 1 comment
Closed

fix for python3-requests 2.32.2 #5434

eaglegai opened this issue Jun 24, 2024 · 1 comment
Labels
bug Something isn't working correctly

Comments

@eaglegai
Copy link
Contributor

eaglegai commented Jun 24, 2024 •
edited

Bug report

python3-requests has used get_connection_with_tls_context instead of get_connection in version 2.32.2
and marked get_connection as deprecated,
we'd better modify as psf/requests#6710 suggested

Steps to reproduce the problem

NA

Environment details

  • Cloud-init version: all include the last version
  • Operating System Distribution:
  • Cloud provider, platform or installer type:
@eaglegai eaglegai added bug Something isn't working correctly new An issue that still needs triage labels Jun 24, 2024
@eaglegai eaglegai mentioned this issue Jun 24, 2024
Merged
@a-dubs a-dubs removed the new An issue that still needs triage label Jun 24, 2024
eaglegai added a commit to eaglegai/cloud-init that referenced this issue Jun 26, 2024
@eaglegai
fix: Add get_connection_with_tls_context() for requests 2.32.2+
0b1ece1 
get_connection() is deprecated in requests 2.32.2+ so this will
allow for the LXDSocketAdapter to avoid using a deprecated api.

Fixed:canonical#5434

Signed-off-by: eaglegai <eaglegai@163.com>
eaglegai added a commit to eaglegai/cloud-init that referenced this issue Jun 26, 2024
@eaglegai
fix: Add get_connection_with_tls_context() for requests 2.32.2+
0611a40 
get_connection() is deprecated in requests 2.32.2+ so this will
allow for the LXDSocketAdapter to avoid using a deprecated api.

Fixed:canonical#5434

Signed-off-by: eaglegai <eaglegai@163.com>
@holmanb
Copy link
Member

holmanb commented Jun 27, 2024

See my analysis on CVE-2024-34195 which prompted this change in upstream requests.

holmanb pushed a commit that referenced this issue Jun 28, 2024
@eaglegai @holmanb
fix: Add get_connection_with_tls_context() for requests 2.32.2+ (#5435)
960c570 
get_connection() is deprecated in requests 2.32.2+ so this will
allow for the LXDSocketAdapter to avoid using a deprecated api.

Fixes GH-5434

Signed-off-by: eaglegai <eaglegai@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@holmanb @eaglegai @a-dubs