Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in distro.net_ops.flush_addr #5648

Closed
Ninjaclasher opened this issue Aug 30, 2024 · 0 comments · Fixed by #5651
Closed

Typo in distro.net_ops.flush_addr #5648

Ninjaclasher opened this issue Aug 30, 2024 · 0 comments · Fixed by #5651
Assignees
Labels
bug Something isn't working correctly

Comments

@Ninjaclasher
Copy link

Bug report

There seems to be a typo in distro.net_ops.flush_addr, which causes an invalid use of iproute2.

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/cloudinit/sources/helpers/digitalocean.py", line 81, in del_ipv4_link_local
    distro.net_ops.flush_addr(nic)
  File "/usr/lib/python3/dist-packages/cloudinit/net/netops/iproute2.py", line 144, in flush_addr
    subp.subp(["ip", "flush", "dev", interface])
  File "/usr/lib/python3/dist-packages/cloudinit/subp.py", line 295, in subp
    raise ProcessExecutionError(
cloudinit.subp.ProcessExecutionError: Unexpected error while running command.
Command: ['ip', 'flush', 'dev', 'eth0']
Exit code: 1
Reason: -
Stdout:
Stderr: Object "flush" is unknown, try "ip help".

This seems to be an obvious regression from 01027e5, since the previous use (01027e5#diff-2fdeaaf3b1491e952eb4c6396294e92160441da230ba0a225eccab85ffe2f75dL89) had addr, while the new function (01027e5#diff-f64049dab9ba0007ced723f722be7e0e70977baa9c4582161b9c04008ac6a4efR144) does not.

Environment details

$ cloud-init --version
/usr/bin/cloud-init 24.2-0ubuntu1~24.04.2
@Ninjaclasher Ninjaclasher added bug Something isn't working correctly new An issue that still needs triage labels Aug 30, 2024
holmanb added a commit to holmanb/cloud-init that referenced this issue Aug 31, 2024
@holmanb holmanb removed the new An issue that still needs triage label Aug 31, 2024
@holmanb holmanb self-assigned this Aug 31, 2024
holmanb added a commit to holmanb/cloud-init that referenced this issue Sep 3, 2024
Drop unnecessary environment variable.

Fixes canonicalGH-5648
holmanb added a commit to holmanb/cloud-init that referenced this issue Sep 3, 2024
Drop unnecessary environment variable.

Fixes canonicalGH-5648
holmanb added a commit to holmanb/cloud-init that referenced this issue Sep 4, 2024
@holmanb holmanb closed this as completed in 3e74d5e Sep 4, 2024
blackboxsw pushed a commit to blackboxsw/cloud-init that referenced this issue Sep 4, 2024
@blackboxsw blackboxsw mentioned this issue Sep 4, 2024
3 tasks
blackboxsw pushed a commit to blackboxsw/cloud-init that referenced this issue Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants