bug(maas): register the correct DatasourceMAASLocal in init-local #5068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorrectly registering DataSourceMAAS for init-local DEP_FILESYSTEM inadvertently short-circuits the _get_data checks performed by DataSourceMAASLocal for presence of network config from initramfs. This results in a 2 minute timeout on physical system reboots because the network stage DataSourceMAAS expects all system networking is already configured and the IMDS to bebe accessible. Correct this registration to do the proper initramfs checks and avoid trying to perform GETs against the IMDS in init-local timeframe when we know network is not yet available. Fixes canonicalGH-5064
blackboxsw
force-pushed
the
maas-register-local-ds
branch
from
10ab82d to
96f26cb
Compare
|
I know this already merged, but reminder in the future to stick to our conventional commits template. It should be |
TheRealFalcon
pushed a commit
to TheRealFalcon/cloud-init
that referenced
this pull request
Mar 19, 2024
…nonical#5068) Incorrectly registering DataSourceMAAS for init-local DEP_FILESYSTEM inadvertently short-circuits the _get_data checks performed by DataSourceMAASLocal for presence of network config from initramfs. This results in a 2 minute timeout on physical system reboots because the network stage DataSourceMAAS expects all system networking is already configured and the IMDS to be accessible. Correct this registration to do the proper initramfs checks and avoid trying to perform GETs against the IMDS in init-local timeframe when we know network is not yet available. Fixes canonicalGH-5064 LP: #2057763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Checklist
Merge type