Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ec2): Correctly identify netplan renderer #5361

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

TheRealFalcon
Copy link
Member

@TheRealFalcon TheRealFalcon commented Jun 3, 2024

Proposed Commit Message

fix(ec2): Correctly identify netplan renderer

Testing

Found with tests/integration_tests/modules/test_hotplug.py::test_multi_nic_hotplug

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@TheRealFalcon TheRealFalcon marked this pull request as ready for review June 3, 2024 21:23
@a-dubs
Copy link
Collaborator

a-dubs commented Jun 3, 2024

nice catch!

@blackboxsw blackboxsw self-requested a review June 3, 2024 22:34
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration test runs happy now! Thanks.

@TheRealFalcon TheRealFalcon merged commit 072711c into canonical:main Jun 4, 2024
23 checks passed
@TheRealFalcon TheRealFalcon deleted the ec2-netplan branch June 4, 2024 02:53
TheRealFalcon added a commit to TheRealFalcon/cloud-init that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants