Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): do not auto stale issues #5775

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

aciba90
Copy link
Contributor

@aciba90 aciba90 commented Oct 3, 2024

Proposed Commit Message

fix(ci): do not auto stale issues

days-before-{stale,close} seems to activate auto staleing of issues.
Demote them to days-before-pr{stale,close} to only act upon PRs.

Rereferences:

- [1] https://github.com/actions/stale
- [2] https://github.com/actions/stale/blob/main/action.yml

Additional Context

https://github.com/actions/stale
82efd3e

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also set days-before-issue-close and days-before-issue-stale to -1. According to the table, if unset, the default is 60 days, and -1 means "don't mark things stale or close".

days-before-{stale,close} seems to activate auto staleing of issues.
Demote them to days-before-pr{stale,close} to only act upon PRs.

Rereferences:

- [1] https://github.com/actions/stale
- [2] https://github.com/actions/stale/blob/main/action.yml
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aciba90 aciba90 merged commit 545e9ac into canonical:main Oct 3, 2024
21 checks passed
@aciba90 aciba90 deleted the no-stale branch October 3, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants