test: add get_syslog_or_console for minimal images without syslog #5793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackboxsw
force-pushed
the
minimal-tests
branch
from
a9276c0
to
57efc02
Compare
TheRealFalcon
requested changes
Oct 7, 2024
| f"Image {CURRENT_RELEASE.os} doesn't contain 'file' util" | ||
| ) | ||
|
|
||
| class_client.execute("apt-get update") |
There was a problem hiding this comment.
Is it worth updating this test to use something other than file? That particular command doesn't seem to be integral to the test.
There was a problem hiding this comment.
Good point, we don't need to use file for this verification/validation. Simplifying this to just check md5sums of the output file.
Minimal images do not have rsyslog installed. As a result, no /var/log/syslog exists. Add helper function get_syslog_or_console to allow minimal images to use pycloudlib.Instance.get_console instead of reading /var/log/syslog.
blackboxsw
force-pushed
the
minimal-tests
branch
from
57efc02
to
6ca01d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Sample jenkins test failures for minimal.
https://jenkins.canonical.com/server-team/job/zzz-chad-jammy-lxd-minimal/lastSuccessfulBuild
Test Steps
Merge type