COS Alerter initial PR #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed-i
reviewed
Mar 17, 2023
Co-authored-by: Leon <82407168+sed-i@users.noreply.github.com>
Closed
dstathis
requested review from
simskij,
rbarry82,
sed-i,
PietroPasotti,
lucabello and
Abuelodelanada
rbarry82
reviewed
Mar 22, 2023
simskij
reviewed
Mar 23, 2023
|
As a general comment, we need to make sure the alerter allows to be used as a watchdog for multiple alertmanagers, which is currently not the case. I don't think the current PR is blocked by that, but we need to make sure we track it as work which still needs to be completed. 👍🏼 |
sed-i
reviewed
Mar 23, 2023
Co-authored-by: Leon <82407168+sed-i@users.noreply.github.com>
Closed
simskij
reviewed
Mar 27, 2023
simskij
reviewed
Mar 27, 2023
PietroPasotti
approved these changes
Mar 27, 2023
simskij
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft for cos-alerter
Todo:
In order to mitigate comments about this. #19, #20