Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly support --shell, --shell-after and --debug on pack #430

Closed
tigarmo opened this issue Aug 22, 2024 · 1 comment · Fixed by #436
Closed

Properly support --shell, --shell-after and --debug on pack #430

tigarmo opened this issue Aug 22, 2024 · 1 comment · Fixed by #436
Labels
Enhancement New feature or request triaged

Comments

@tigarmo
Copy link
Contributor

tigarmo commented Aug 22, 2024

What needs to get done

Update the PackCommand so that --shell, --shell-after and --debug work as the user expects them to for the packing process itself (and not just for the lifecycle commands that might come before it).

Why it needs to get done

There is a real user need for the options on pack, specially --debug as the packing process is involved enough to fail sometimes.
Also the inconsistency is annoying, heh

@tigarmo tigarmo added Enhancement New feature or request triaged labels Aug 22, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3288.

This message was autogenerated

tigarmo added a commit that referenced this issue Sep 2, 2024
`--shell` and `--shell-after` are implemented for a) consistency with the other
lifecycle commands, and b) because it makes sense to want to inspect the build
environment at packing time, considering that there are packing-related steps,
like writing the metadata file, that the users don't have a way to inspect
otherwise (short of examining the final artefact).

`--debug` is improved to actually shell into the build environment when the
packing itself failed, as opposed to the previous behavior of only debugging
failures that happen during the lifecycle steps.

Fixes #430
tigarmo added a commit that referenced this issue Sep 4, 2024
`--shell` and `--shell-after` are implemented for a) consistency with the other
lifecycle commands, and b) because it makes sense to want to inspect the build
environment at packing time, considering that there are packing-related steps,
like writing the metadata file, that the users don't have a way to inspect
otherwise (short of examining the final artefact).

`--debug` is improved to actually shell into the build environment when the
packing itself failed, as opposed to the previous behavior of only debugging
failures that happen during the lifecycle steps.

Fixes #430

---------

Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
linostar pushed a commit to linostar/craft-application that referenced this issue Dec 4, 2024
`--shell` and `--shell-after` are implemented for a) consistency with the other
lifecycle commands, and b) because it makes sense to want to inspect the build
environment at packing time, considering that there are packing-related steps,
like writing the metadata file, that the users don't have a way to inspect
otherwise (short of examining the final artefact).

`--debug` is improved to actually shell into the build environment when the
packing itself failed, as opposed to the previous behavior of only debugging
failures that happen during the lifecycle steps.

Fixes canonical#430

---------

Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant