Some fixes to unbreak main #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszd21
reviewed
May 31, 2024
mr-cal
reviewed
May 31, 2024
mr-cal
approved these changes
May 31, 2024
lengau
approved these changes
May 31, 2024
Version 2.32.0 breaks with the "http+unix" protocol used by requests-unixsocket, which in turn is used by craft-parts. Pin this as a "dev" dependency since the issue is in craft-parts, and not here. Ref: msabramo/requests-unixsocket#73
tigarmo
force-pushed
the
fix-craft-app-main
branch
from
63e4004
to
e3f9442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox?