feat: exponential backoff for launchpad retries #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only covers those calls that currently have a known Exception type.
lengau
approved these changes
May 31, 2024
mr-cal
approved these changes
Jun 3, 2024
tigarmo
force-pushed
the
CRAFT-2626-exponential-fallback
branch
from
2284e6e to
307c18f
Compare
This commit changes the retry() strategy: instead of sleeping a constant 3 seconds between attempts, each attempt sleeps twice as much as the previous one (starting at 2 seconds). There is a cap of 5 attempts, so that the call to retry can sleep() for at most 2+4+8+16+32 = 62 seconds.
tigarmo
force-pushed
the
CRAFT-2626-exponential-fallback
branch
from
307c18f to
45a1df0
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #352, only the last commit is new.
This commit changes the retry() strategy: instead of sleeping a constant
3 seconds between attempts, each attempt sleeps twice as much as the previous
one (starting at 2 seconds). There is a cap of 5 attempts, so that the call
to retry can sleep() for at most 2+4+8+16+32 = 62 seconds.