Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check if lxd snap is installed #585

Merged
merged 12 commits into from
Jun 21, 2024
Merged

fix: check if lxd snap is installed #585

merged 12 commits into from
Jun 21, 2024

Commits on Jun 20, 2024

  1. fix: check if lxd snap is installed 

    Check if the lxd snap is installed by querying the snapd socket
instead of looking for an executable in the path, as lxd can use
auto-installer stubs.

Co-authored-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
    @cmatsuoka @mr-cal
    cmatsuoka and mr-cal committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    ba258a3 View commit details
    Browse the repository at this point in the history

  2. chore: address linter warnings 

    Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
    @cmatsuoka
    cmatsuoka committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    f489fed View commit details
    Browse the repository at this point in the history

  3. chore: address linter warnings 

    Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
    @cmatsuoka
    cmatsuoka committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    711e060 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. tests: update lxd install detector unit test 

    Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
    @cmatsuoka
    cmatsuoka committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    b1e8962 View commit details
    Browse the repository at this point in the history

  2. chore: address linter warnings 

    Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
    @cmatsuoka
    cmatsuoka committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    afc91ba View commit details
    Browse the repository at this point in the history

  3. chore: address linter warnings 

    Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
    @cmatsuoka
    cmatsuoka committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    9af3e97 View commit details
    Browse the repository at this point in the history

  4. chore: pin requests to a version that works for us 

    Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
    @cmatsuoka
    cmatsuoka committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    48031e0 View commit details
    Browse the repository at this point in the history

  5. tests: cover executable in path and arch/nixos scenarios 

    Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
    @cmatsuoka
    cmatsuoka committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    dd67505 View commit details
    Browse the repository at this point in the history

  6. chore: capitalize lxd name 

    Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
    @cmatsuoka
    cmatsuoka committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    03ac670 View commit details
    Browse the repository at this point in the history

  7. chore: use british english 

    Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
    @cmatsuoka
    cmatsuoka committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    92f6358 View commit details
    Browse the repository at this point in the history

  8. chore: address linter warnings 

    Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
    @cmatsuoka
    cmatsuoka committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    059cbc5 View commit details
    Browse the repository at this point in the history

  9. chore: put back linter pragma that ruff told us to remove 

    Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
    @cmatsuoka
    cmatsuoka committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    24585c3 View commit details
    Browse the repository at this point in the history