[MISC] Fix unit tests and add juju 3.6 test runs #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dragomirp
commented
Jan 14, 2025
•
dragomirp
commented
- Fix unit test failures e.g. here
- Add juju 3.6 to the integration test matrix
dragomirp
changed the title
dragomirp
commented
Jan 14, 2025
There was a problem hiding this comment.
We should most probably also remove some of the other Juju 3 versions
There was a problem hiding this comment.
@deusebio @delgod @Mehdi-Bendriss do you mind to clean the list here and keep 2.9 and 3.6 LTS only?
LGTM from me to test supported Juju releases only.
dragomirp
commented
Jan 14, 2025
| @@ -43,14 +43,14 @@ def test_cached_secret_is_cached(harness, mocker): | |||
| secret = CachedSecret(harness.charm, "mylabel") | |||
| secret.add_secret(content={"rumour": "Community Movie on the way"}, scope="app") | |||
| patched_get = mocker.patch("ops.model.Model.get_secret") | |||
| patched_get_content = mocker.patch("ops.Secret.get_content") | |||
| patched_get_content = patched_get.return_value.get_content | |||
There was a problem hiding this comment.
get_content() is called from the mock get_secret()
welpaolo
approved these changes
Jan 15, 2025
taurus-forever
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
@deusebio @delgod @Mehdi-Bendriss do you mind to clean the list here and keep 2.9 and 3.6 LTS only?
LGTM from me to test supported Juju releases only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.