patch(build_charm.yaml): Add comment about libpq-dev
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
requested review from
paulomach,
taurus-forever,
dragomirp and
shayancanonical
shayancanonical
approved these changes
Mar 7, 2024
| @@ -100,6 +100,7 @@ jobs: | |||
| echo "$HOME/.local/bin" >> "$GITHUB_PATH" | |||
| - name: (GitHub-hosted ARM runner) Install libpq-dev | |||
| if: ${{ matrix.base.runner == 'Ubuntu_ARM64_4C_16G_01' }} | |||
| # Needed for `charmcraftcache` to resolve dependencies (for postgresql charms with psycopg2) | |||
There was a problem hiding this comment.
is there a way to install this only for postgres charms?
There was a problem hiding this comment.
yes, but imo not worth it
we could read charmcraft.yaml build-packages, but that shouldn't be needed to install a binary version of a python package
(we already read build-packages when building wheels from source on ccc-hub)
psycopg2 is a special python dep in that it requires an apt package to install from binary, which I believe is quite rare
gh-hosted X64 runners have libpq-dev installed by default, so installing it is the easiest workaround
There was a problem hiding this comment.
Even if there is, it may become hard to maintain per charm dependencies. I thinks it's just simpler to allow some bloat here
taurus-forever
approved these changes
Mar 7, 2024
paulomach
approved these changes
Mar 7, 2024
| @@ -100,6 +100,7 @@ jobs: | |||
| echo "$HOME/.local/bin" >> "$GITHUB_PATH" | |||
| - name: (GitHub-hosted ARM runner) Install libpq-dev | |||
| if: ${{ matrix.base.runner == 'Ubuntu_ARM64_4C_16G_01' }} | |||
| # Needed for `charmcraftcache` to resolve dependencies (for postgresql charms with psycopg2) | |||
There was a problem hiding this comment.
Even if there is, it may become hard to maintain per charm dependencies. I thinks it's just simpler to allow some bloat here
carlcsaposs-canonical
referenced
this pull request
in canonical/mysql-router-k8s-operator
Mar 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [canonical/data-platform-workflows](https://github.com/canonical/data-platform-workflows) | action | major | `v12.6.2` -> `v13.0.0` | | [pytest-operator-cache](https://github.com/canonical/data-platform-workflows) | integration | major | `v12.6.2` -> `v13.0.0` | | [pytest-operator-groups](https://github.com/canonical/data-platform-workflows) | integration | major | `v12.6.2` -> `v13.0.0` | --- ### Release Notes <details> <summary>canonical/data-platform-workflows (canonical/data-platform-workflows)</summary> ### [`v13.0.0`](https://github.com/canonical/data-platform-workflows/releases/tag/v13.0.0) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v12.7.2...v13.0.0) ##### What's Changed - breaking(release_charm.yaml): Remove support for `upstream-sources` by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [https://github.com/canonical/data-platform-workflows/pull/158](https://github.com/canonical/data-platform-workflows/pull/158) **Full Changelog**: canonical/data-platform-workflows@v12...v13.0.0 ### [`v12.7.2`](https://github.com/canonical/data-platform-workflows/releases/tag/v12.7.2) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v12.7.1...v12.7.2) ##### What's Changed - patch: Add \_sync_docs.yaml by [@​a-velasco](https://github.com/a-velasco) in [https://github.com/canonical/data-platform-workflows/pull/157](https://github.com/canonical/data-platform-workflows/pull/157) ##### New Contributors - [@​a-velasco](https://github.com/a-velasco) made their first contribution in [https://github.com/canonical/data-platform-workflows/pull/157](https://github.com/canonical/data-platform-workflows/pull/157) **Full Changelog**: canonical/data-platform-workflows@v12.7.1...v12.7.2 ### [`v12.7.1`](https://github.com/canonical/data-platform-workflows/releases/tag/v12.7.1) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v12.7.0...v12.7.1) ##### What's Changed - patch(build_charm.yaml): Add comment about `libpq-dev` by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [https://github.com/canonical/data-platform-workflows/pull/156](https://github.com/canonical/data-platform-workflows/pull/156) **Full Changelog**: canonical/data-platform-workflows@v12.7.0...v12.7.1 ### [`v12.7.0`](https://github.com/canonical/data-platform-workflows/releases/tag/v12.7.0) [Compare Source](https://github.com/canonical/data-platform-workflows/compare/v12.6.2...v12.7.0) ##### What's Changed - compatible(release_rock.yaml): Release multi-architecture image by [@​carlcsaposs-canonical](https://github.com/carlcsaposs-canonical) in [https://github.com/canonical/data-platform-workflows/pull/155](https://github.com/canonical/data-platform-workflows/pull/155) **Full Changelog**: canonical/data-platform-workflows@v12.6.2...v12.7.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 1am and before 3am every weekday" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/mysql-router-k8s-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42OC4xIiwidXBkYXRlZEluVmVyIjoiMzcuMjQ1LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.