Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dex ROCK #11

Closed
misohu opened this issue May 21, 2024 · 1 comment · Fixed by #12
Closed

Update dex ROCK #11

misohu opened this issue May 21, 2024 · 1 comment · Fixed by #12
Labels
enhancement New feature or request Kubeflow 1.9

Comments

@misohu
Copy link
Member

misohu commented May 21, 2024

Context

Each charm in Kubeflow has a ROCK (or a set of ROCKs) it is using. The process of upgrading ROCKs usually means going to the component's upstream repository Dockerfile, comparing current ROCK version against the one in the repository and adding the missing bits.

What needs to get done

  1. Clone the upstream's kubeflow repository.
  2. Go to desired Dockerfile (first line in rockcraft.yaml should specify the full path).
  3. Checkout to the branch or tag of the target version.
  4. Checkout to the branch or tag of the version of the current ROCK.
  5. Compare both files to spot the differences.

Definition of Done

  1. New ROCK is ready.
  2. Tests are passing.
  3. ROCK is published under charmedkubeflow Dockerhub account.
@misohu misohu added enhancement New feature or request Kubeflow 1.9 labels May 21, 2024
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5722.

This message was autogenerated

DnPlas added a commit that referenced this issue Jun 4, 2024
@DnPlas
chore: bump 2.36 -> 2.39
ad4b292 
Bump the rock workload version to 2.39.1.

Fixes #11
@DnPlas DnPlas mentioned this issue Jun 4, 2024
Merged
@DnPlas DnPlas closed this as completed in #12 Jun 5, 2024
DnPlas added a commit that referenced this issue Jun 5, 2024
@DnPlas
chore: bump 2.36 -> 2.39 (#12)
a91817e 
Bump the rock workload version to 2.39.1.

Fixes #11
mvlassis pushed a commit that referenced this issue Jul 4, 2024
@DnPlas @mvlassis
chore: bump 2.36 -> 2.39 (#12)
70f6b8a 
Bump the rock workload version to 2.39.1.

Fixes #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Kubeflow 1.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump 2.36 -> 2.39 canonical/dex-auth-rocks
1 participant
@misohu