Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport patches to enable support for changes to latest golang #150

Merged

Conversation

jocado
Copy link
Contributor

@jocado jocado commented Jul 27, 2023

Without this patch, snap builds produce a snap with a non-functional docker cli and client, they fail with http: invalid Host header

REF: moby/moby#45935

Without this patch, snap builds produce a snap with a non-funtional
docker cli and client, they fail with `http: invalid Host header`

REF: moby/moby#45935
@jocado
Copy link
Contributor Author

jocado commented Jul 27, 2023

For ref, here is an example failure for an action log: https://github.com/docker-snap/docker-snap/actions/runs/5684149041/job/15406223201#step:10:6

@lucaskanashiro
Copy link
Contributor

Thanks for this PR @jocado ! I see the patch you are proposing was already merged upstream:

moby/moby@dab9ffb

This fix is present in version 24.0.5:

https://github.com/moby/moby/releases/tag/v24.0.5

I am planning to push 24.0.5 to latest/edge soon but it would take a while until we promote it to latest/stable. So I think the best route is to merge your change, follow all the process to promote it to latest/stable and then update latest/edge to 24.0.5.

The smoke test also passed against your branch, so I believe we are good to go.

@lucaskanashiro lucaskanashiro merged commit 85aa612 into canonical:main Aug 23, 2023
@lucaskanashiro
Copy link
Contributor

If you want to test yourself, I just uploaded it to the snap store:

Revision 2903 created for 'docker' and released to 'latest/edge'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants