-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor of the foundational code per the updated spec #11
Conversation
… settings are donw
…ds when settings change
…different window types will have different values
…to foundation-refactor
@hbatagelo Fixed those two issues! Good catch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few additional suggestions, this time about window.dart
.
One small nitpick: the text shown in the regular windows still appears to be from the older reference app (It's fine to update it in a future PR).
examples/multi_window_ref_app/lib/app/window_controller_render.dart
Outdated
Show resolved
Hide resolved
examples/multi_window_ref_app/lib/app/window_controller_render.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also:
- Consider adding
vector_math: ^2.1.4
as a dependency inpubspec.yaml
. - Check whether
CPP_WRAPPER_SOURCES_WINDOWING
is needed inexamples/multi_window_ref_app/windows/flutter/CMakeLists.txt
. It doesn't seem to work with the 1st engine PR.
What's new?
A lot! I completely refactored
window.dart
and how the multi window reference app works.This work:
createX
methods that reach out to the engine from the dart widgetsRegularWindow
) that can be declaratively used to handle the creation and deletion of a windowWindowController
(e.g.RegularWindowController
) which enables callers to make changes to a window and listen for changes on a windowOverall, this is a much needed change! It significantly changed the way that the multi window reference app is done, but for the better in my opinion.
Side note
I have a feeling that it will be a better use of our time to not merge this up in the longer run, but rather to make new PRs off of this. The API has changed so drastically that the newer concepts map very little onto existing PRs.