-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chart displaying available applications #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the jobs per application metric would be better displayed as a bar chart. The current chart doesn't seem to intuitive to me
The problem with bar charts is that the focus is on the graph and not on the legend. The idea here is to present a list of available applications, so the focus should be on the text. My first version was as follows: |
What about an horizontal bar chart, with the legend on the left side? |
@arturo-seijas This would look like But as mentioned the emphasis would be a bit fewer on the application names. There is also already a panel at the bottom of the dashboard that shows the application share and looks like this: This could simply be reused and moved to the top to indicate the list of applications. Perhaps @jdkandersson can give his opinion on this, as the new panel was requested by him. |
When I see the application share I find too difficult to see the values for those that are not at the top nor bottom. In the screenshot above, what are the values for |
@arturo-seijas Ok, gotcha. I'm fine with using bar charts, but I think I need to re-confirm that this meets the acceptance criteria, as the original story was just to visualise the names of applications, not the number of jobs or anything. I just added it because the log panel only showing the names didn't look "pretty" to me. See also the jira ticket. |
This reverts commit 767bb62.
@cbartz I am wondering if all we need is an easy way for users to search by application- can we change the Flavors textbox to be a dropdown instead? Something like- |
@varshigupta12 The text box is automatically generated by Grafana and is not intended for further customisation. There are drop-down menus for "Query variables", but unfortunately these are not applicable here because the "flavor" is not a real label. It might be possible to turn it into a real label, which might require some customisation of the grafana-agent charm. I think we (@jdkandersson and I) decided not to put too much effort into solving this problem, but it could certainly be investigated together with the observability team. |
Yeh we couldn't find a way to do a drop down and this is the alternative. Perhaps we do the horizontal bar chart and make the number the number of available runners? I think that would be a useful chart anyway |
@jdkandersson Can you please review? Thanks. |
Test coverage for aeebd7b
Static code analysis report
|
* Add panel for available applications * Rename flavor -> application * Rename flavor -> application * pin requests < 2.32.0 * flavours -> applications * use bar gauge * use bar gauge * update docs * Revert "pin requests < 2.32.0" This reverts commit 767bb62. * use barchart * change to available runners * update docs * lint
Applicable spec: n/a
Overview
For the short-term board, list all available runners (idle runners after last reconciliation).
For the long-term board, show all runners created per application.
![image](https://private-user-images.githubusercontent.com/4182921/334309508-1c34d159-d3d9-4a92-abd3-8a6497a4b39a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ2MTczNTEsIm5iZiI6MTcyNDYxNzA1MSwicGF0aCI6Ii80MTgyOTIxLzMzNDMwOTUwOC0xYzM0ZDE1OS1kM2Q5LTRhOTItYWJkMy04YTY0OTdhNGIzOWEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjVUMjAxNzMxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDI2NGIwYjI4ZmUxZGEyMWU1ZWY1MzA4ZGNkMmFjNmViOWRkMWI2N2Y0OTM0NmNiNmI2M2VlMzlkM2QyMDk0ZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.m9yQzJOGlB8sn_G7xNFq7SN_rAHBxJ33YlmU6-3HaGE)
Rationale
Juju Events Changes
n/a
Module Changes
n/a
Library Changes
n/a
Checklist
src-docs
urgent
,trivial
,complex
)