feat: Add node device discovery API endpoint interaction #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachin120
changed the title
skatsaounis
requested changes
Feb 19, 2024
There was a problem hiding this comment.
I added some suggestions for changes. Plus, since we are implementing discoveries, I would also like you to add the following:
POST /MAAS/api/2.0/discovery/op-clearPOST /MAAS/api/2.0/discovery/op-clear_by_mac_and_ip
POST /MAAS/api/2.0/discovery/op-scan can be skipped for now since it is a heavy operation and I am not sure if we only have to declare some lines of code or do more things to support it.
sachin120
force-pushed
the
discovery
branch
2 times, most recently
from
b47031d to
7427a58
Compare
sachin120
force-pushed
the
discovery
branch
2 times, most recently
from
7357ea8 to
6d6fdd2
Compare
Signed-off-by: Sachin Shingare <doitqik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Listing API interaction for node device discovery