Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update for migration #81

Merged
merged 8 commits into from
Jun 26, 2024
Merged

refactor: Update for migration #81

merged 8 commits into from
Jun 26, 2024

Conversation

SK1Y101
Copy link
Member

@SK1Y101 SK1Y101 commented Jun 26, 2024

  • Change go.mod to use canonical/gomaasclient
  • Update readme to reflect new changes
  • update all go files to reference canonical/gomaasclient

@SK1Y101 SK1Y101 requested review from troyanov and skatsaounis June 26, 2024 10:55
@SK1Y101 SK1Y101 marked this pull request as ready for review June 26, 2024 10:56
Copy link
Member

@troyanov troyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but some imports need to be fixed

api/ssl_keys.go Outdated Show resolved Hide resolved
api/ssh_keys.go Outdated Show resolved Hide resolved
api/version.go Outdated Show resolved Hide resolved
api/vlan.go Outdated Show resolved Hide resolved
api/users.go Outdated Show resolved Hide resolved
@troyanov troyanov self-requested a review June 26, 2024 11:54
Copy link
Member

@troyanov troyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SK1Y101 SK1Y101 merged commit d1c165b into master Jun 26, 2024
4 checks passed
@SK1Y101 SK1Y101 deleted the migration-patch branch June 26, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants