Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to ROCK files and integration tests. #21

Merged
merged 11 commits into from
Jul 30, 2024

Conversation

aznashwan
Copy link
Contributor

@aznashwan aznashwan commented Jul 29, 2024

Depends on: canonical/k8s-test-harness#26

This patchset includes numerous fixes to the integration tests and some ROCKs, most notably:

  • switching integration tests to module-scoped harness (the upstream goharbor/harbor-helm chart re-uses names for PVCs which can cross-pollute testing between image version sets)
  • ensures harbor-jobservice images' entrypoint service doesn't crash too quickly for Pebble to bother restarting it
  • fix harbor-db:v2.6.3 utility binaries symlinks
  • fix build-snaps golang version conflicts in trivy-adapter-photon:v2.6.3
  • fix registry-photon entrypoint arguments issue when deploying via the upstream goharbor/harbor-helm chart
  • formatting fixes for all sanity tests

Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
…eanup.

Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
@aznashwan aznashwan requested a review from a team as a code owner July 29, 2024 14:34
@aznashwan aznashwan changed the title Minor fixes Various fixes to ROCK files and integration tests. Jul 29, 2024
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
…art it.

Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
@aznashwan
Copy link
Contributor Author

With the unfortunate exception of the harbor-trivy StatefulSet, which seems to have consistent but unrelated PVC provisioning issues on the GitHub runner, this PR finally sees all other sanity and integration tests passing (on amd64, at least).

Although I'd love to get to the bottom of the trivy-adapter's PVC allocation issues on the GH runner eventually, I can vouch that the exact Helm deployment commands in the integration tests consistently run fine in manual testing on the k8s v1.30.3 756 latest/edge snap across all 3 versions and am at a loss as to why it wouldn't on the GH runners.

Given how much of a time sink debugging the runners has already been, I think it's time to cut our losses for now and return to it later if the issue is ever consistent on non-GH-runner environments.

@bschimke95
Copy link
Collaborator

Copy link
Collaborator

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschimke95 bschimke95 merged commit 81b3980 into canonical:main Jul 30, 2024
5 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants