Feat: Add Terraform modules #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: OK
Libraries: Out of sync
labels
github-actions
bot
added
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: Out of sync
labels
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
orfeas-k
approved these changes
Sep 25, 2024
mvlassis
added a commit
that referenced
this pull request
Sep 26, 2024
* Add Terraform charms * Update format * Update action * Update README.md * Remove channel from terraform action * Update default Terraform channel * Update default Terraform channel
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #552 and #530.
This PR creates a
terraform/directory in each charm that hosts the Terraform module. It follows the structure proposed in this spec.To test the module:
tox -e tflintto ensure that linting is correctterraform/directory and runterraform init.terraform apply -var "channel=latest/edge" -var "model_name=kubeflow" --auto-approveand wait until the charm isActiveandIdle.