Fix to use postgres as the controller credential store #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
force-pushed
the
postgres-secret-storage-fix
branch
from
da12adc to
f138448
Compare
babakks
approved these changes
Jul 28, 2023
alesstimec
approved these changes
Jul 28, 2023
mina1460
reviewed
Jul 28, 2023
mina1460
approved these changes
Jul 28, 2023
kian99
force-pushed
the
postgres-secret-storage-fix
branch
from
7912153 to
030c1be
Compare
Jimm could error out if no credential store is setup but this would require several tests to change and is best left for a separate PR
ale8k
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using Postgres for secret storage wasn't previously implemented correctly in the server setup. The dialer interface that dials Juju controllers needs to be configured with the same secret store as JIMM's credential store.
Also added a check before dialling to ensure the controller username and password are not until otherwise JIMM will panic.
Engineering checklist
Check only items that apply