Tweak import model to avoid manual construction of user tag string #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
requested review from
alesstimec,
ale8k,
babakks and
mina1460
as code owners
alesstimec
approved these changes
Oct 16, 2023
| if newOwner != "" { | ||
| // Switch the model to be owned by the specified user. | ||
| ownerString = names.UserTagKind + "-" + newOwner | ||
| if !names.IsValidUser(newOwner) { |
internal/jimm/controller.go
Outdated
| if newOwner != "" { | ||
| // Switch the model to be owned by the specified user. | ||
| ownerString = names.UserTagKind + "-" + newOwner | ||
| if !names.IsValidUser(newOwner) { | ||
| return errors.E(op, "invalid new username for new model owner") |
There was a problem hiding this comment.
perhaps also include the bad request code
ale8k
approved these changes
Oct 16, 2023
kian99
force-pushed
the
minor-refactor-import-model
branch
from
a8bbe54 to
2b896eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tweak import model to avoid manual construction of user tag string - done to address #1056 (comment)
Engineering checklist
Check only items that apply