Support running on ARM #1088
Merged
Support running on ARM #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huwshimi
requested review from
alesstimec,
kian99,
ale8k,
babakks and
mina1460
as code owners
huwshimi
commented
Nov 15, 2023
| @@ -1,7 +1,8 @@ | |||
| #!/bin/sh | |||
|
|
|||
| # Grab JQ for ease of use. | |||
| wget -O jq https://github.com/jqlang/jq/releases/download/jq-1.7/jq-linux-amd64 | |||
| ARCH=$(arch | sed s/aarch64/arm64/ | sed s/x86_64/amd64/) | |||
There was a problem hiding this comment.
This method of getting the arch is a lot less nice than dpkg --print-architecture but the Vault Docker image uses Alpine which doesn't appear to have an easy way to get the base arch.
kian99
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support running inside a multipass on ARM.
Engineering checklist
Check only items that apply
Test instructions
Note: this PR will need to land so that you can get past the
make pull/candidstep.docker compose --profile dev upstep should complete successfully (you should be able to runmake get-local-authand get a response).Notes for code reviewers