Extra setup details #1089
Extra setup details #1089
Conversation
huwshimi
requested review from
alesstimec,
kian99,
ale8k,
babakks and
mina1460
as code owners
| After this initial setup, subsequent use of the compose can be done with `docker | ||
| compose --profile dev up --force-recreate` (it may be necessary to run `docker | ||
| compose down -v --remove-orphans` first). |
There was a problem hiding this comment.
Is there is a better way to explain this?
There was a problem hiding this comment.
Are you looking for an explanation of the extra flags? Or just a rewording to make it clearer?
There was a problem hiding this comment.
I wasn't sure if we should explain why it's necessary to run, or what error to look out for.
There was a problem hiding this comment.
I think it's okay like this, a quick google would reveal a better answer likely anyway
local/README.md
Outdated
| 1. The following commands might need to be run to work around an [LXC networking | ||
| issue](https://github.com/docker/for-linux/issues/103#issuecomment-383607773): | ||
| `sudo iptables -F FORWARD && sudo iptables -P FORWARD ACCEPT`. | ||
| 2. Install Juju: `sudo snap install juju`. |
There was a problem hiding this comment.
Should this specify a minimum Juju version?
There was a problem hiding this comment.
Yes in fact, this version of JIMM with OpenFGA requires Juju 3.3 and up (though it also works with Juju 3.2 but officially 3.3 is the first supported version).
local/README.md
Outdated
| 1. The following commands might need to be run to work around an [LXC networking | ||
| issue](https://github.com/docker/for-linux/issues/103#issuecomment-383607773): | ||
| `sudo iptables -F FORWARD && sudo iptables -P FORWARD ACCEPT`. | ||
| 2. Install Juju: `sudo snap install juju`. |
There was a problem hiding this comment.
Yes in fact, this version of JIMM with OpenFGA requires Juju 3.3 and up (though it also works with Juju 3.2 but officially 3.3 is the first supported version).
| After this initial setup, subsequent use of the compose can be done with `docker | ||
| compose --profile dev up --force-recreate` (it may be necessary to run `docker | ||
| compose down -v --remove-orphans` first). |
There was a problem hiding this comment.
Are you looking for an explanation of the extra flags? Or just a rewording to make it clearer?
local/README.md
Outdated
| 10. `docker compose --profile dev up` if you encounter an error like "Error response from daemon: network ... not found" then the command `docker compose --profile dev up --force-recreate` should help. | ||
|
|
||
| After this initial setup, subsequent use of the compose can be done with `docker compose --profile dev up --force-recreate` | ||
| 5. Ensure you are in the root JIMM directory. |
There was a problem hiding this comment.
I think the numbering skips 4.
Description
Added some additional set up instructions for developers.